Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy levels: migrate protected versions #7092

Merged
merged 1 commit into from May 18, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 18, 2020

This migrates all protected to public on .org,
and to private on .com.

This migrates all protected to public on .org,
and to private on .com.
@stsewd
Copy link
Member Author

@stsewd stsewd commented May 18, 2020

Tested this locally

Screenshot_2020-05-18 Versions - Read the Docs for Business
Screenshot_2020-05-18 Versions - Read the Docs for Business(1)

Screenshot_2020-05-18 Versions Read the Docs
Screenshot_2020-05-18 Versions Read the Docs(1)

Protected versions are migrated correctly for both sites

@stsewd stsewd requested a review from May 18, 2020
Copy link
Member

@ericholscher ericholscher left a comment

👍 -- this is a good change

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 18, 2020

Actually -- is there a reason we don't want protected versions to migrate the same on the .com, thinking more about this? Isn't public and hidden the same as protected? This could break links to existing versions, if they were previously protected.

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 18, 2020

@ericholscher we treat protected versions as private on .com, you can check this on the queryset.

@ericholscher ericholscher merged commit dc12970 into master May 18, 2020
2 checks passed
@ericholscher ericholscher deleted the migrate-protected-versions branch May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants