Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting for storing pageviews #7097

Merged
merged 3 commits into from May 19, 2020
Merged

Add a setting for storing pageviews #7097

merged 3 commits into from May 19, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented May 19, 2020

This is so we can disable it if needed based on DB load.

This is so we can disable it if needed based on DB load.
@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented May 19, 2020

Would this make more sense behind a feature flag and done on a per-project basis?

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented May 19, 2020

It certainly could, at least if we wanted to test the load.

@ericholscher ericholscher merged commit c8bbcdc into master May 19, 2020
1 check was pending
@ericholscher ericholscher deleted the add-pageview-settings branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants