Fix flaky test #7148
Merged
Fix flaky test #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, it was the cache. If your computer is fast enough, the same project slug is updated in the same second. With milliseconds hopefully is hard to hit. Also, set_urlconf to None and to the current urlconf is already done automatically in django 2.2 https://github.com/django/django/blob/stable/2.2.x/django/core/handlers/base.py#L94-L95 https://github.com/django/django/blob/stable/2.2.x/django/core/handlers/base.py#L166
stsewd
reviewed
Jun 1, 2020
| @@ -152,7 +149,7 @@ def test_long_bad_subdomain(self): | |||
|
|
|||
| @pytest.mark.proxito | |||
| @override_settings(PUBLIC_DOMAIN='dev.readthedocs.io') | |||
| class MiddlewareURLConfTests(RequestFactoryTestMixin, TestCase): | |||
There was a problem hiding this comment.
We don't make use of this mixin in any of the tests
ericholscher
reviewed
Jun 1, 2020
I don't quite understand what was breaking here. Why would the time set be an issue?
|
@ericholscher the tests use the same project slug, so the next test can be created between the same second, this making use the same cached urlconf module instead of evaluating the new one. You can replicate this by deleting the seconds from the timestamp. |
|
Oh I see, that makes sense. |
ericholscher
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Turns out, it was the cache.
If your computer is fast enough,
the same project slug is updated in the same second.
The cache is done at the django level, so not much we can do about it from outside.
With milliseconds hopefully is hard to hit.
Also, set_urlconf to None and to the current urlconf is already done automatically in django 2.2
https://github.com/django/django/blob/stable/2.2.x/django/core/handlers/base.py#L94-L95
https://github.com/django/django/blob/stable/2.2.x/django/core/handlers/base.py#L166