Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom URLConf redirects #7155

Merged
merged 5 commits into from Jun 8, 2020
Merged

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 3, 2020

This fixes our automatic redirects to work properly.

@ericholscher ericholscher requested review from agjohnson and a team Jun 4, 2020
@ericholscher ericholscher changed the title Only set default values when they're in the URLConf Fix custom URLConf redirects Jun 5, 2020
Copy link
Contributor

@agjohnson agjohnson left a comment

Looks good to me! Including @humitos for review as I'm not the best to comment on proxito.

@agjohnson agjohnson requested a review from humitos Jun 5, 2020
humitos
humitos approved these changes Jun 8, 2020
Copy link
Member

@humitos humitos left a comment

Looks correct to me. I'm not super familiarized with the custom URLconf, tho :)

@ericholscher ericholscher merged commit 853f473 into master Jun 8, 2020
2 checks passed
@ericholscher ericholscher deleted the redirect-urlconf-properly branch Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants