Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow projects to opt-out of analytics #7175

Merged
merged 3 commits into from Jun 16, 2020

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 10, 2020

  • Project maintainers may completely disable analytics
  • Requires documentation to be rebuilt to take effect

Fixes #7151

Screenshot

Screen Shot 2020-06-09 at 9 40 14 PM

- Project maintainers may completely disable analytics
- Requires documentation to be rebuilt to take effect
readthedocs/api/v2/serializers.py Show resolved Hide resolved
* Going to :guilabel:`Admin` > :guilabel:`Advanced Settings` in your project.
* Check the box **Disable Analytics**.

Your documentation will need to be rebuilt for this change to take effect.
Copy link
Member

@stsewd stsewd Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nmaybe make it clear that all versions of the documentation will need to be rebuilt (not just one)

readthedocs/api/v3/serializers.py Show resolved Hide resolved
readthedocs/projects/models.py Show resolved Hide resolved
stsewd
stsewd approved these changes Jun 10, 2020
@ericholscher
Copy link
Member

ericholscher commented Jun 12, 2020

Should we add logic to the footer to add these projects users to analytics via the analytics_event task? Seems like a good use-case for that, and would allow us to continue to count these users in a privacy-respecting way.

@davidfischer
Copy link
Contributor Author

davidfischer commented Jun 12, 2020

Should we add logic to the footer to add these projects users to analytics via the analytics_event task?

I was planning on it.

Copy link
Member

@ericholscher ericholscher left a comment

I'm 👍 on this, seems useful to have fully untracked docs pages.

@davidfischer davidfischer merged commit 34edf4c into master Jun 16, 2020
2 checks passed
@davidfischer davidfischer deleted the davidfischer/analytics-opt-out branch Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants