Search: refactor json parser #7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use classes - Get the code ready to index directly form html - Remove duplicated tests - Rename some functions/variables Logic is the same
stsewd
reviewed
Jun 11, 2020
| @@ -1,32 +0,0 @@ | |||
| import os | |||
There was a problem hiding this comment.
We already have a more general tests in search/tests/test_parsers.py
ericholscher
approved these changes
Jun 15, 2020
readthedocs/projects/models.py
Outdated
| parser_class = ( | ||
| SphinxParser if self.version.is_sphinx_type else MkDocsParser | ||
| ) | ||
| parser = parser_class(self.project, self.version) |
There was a problem hiding this comment.
We likely only need a version here, since it already relates to project.
There was a problem hiding this comment.
I thought we were doing that for performance
readthedocs.org/readthedocs/projects/models.py
Lines 1314 to 1319 in fb5b8c8
But I think django will still do another query at least we are not doing a prefetch somewhere
| - foo.rst | ||
| - foo/index.rst | ||
|
|
||
| Both lead to foo/index.html. |
There was a problem hiding this comment.
This is a good docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Logic is the same