Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature flag to use latest RTD Sphinx ext #7198

Merged
merged 2 commits into from Jun 19, 2020

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 16, 2020

This is useful to test the latest versions of the extension without pushing it live for everyone.

This is useful to test the latest versions of the extension
without pushing it live for everyone.
@davidfischer davidfischer requested a review from Jun 16, 2020
Copy link
Member

@ericholscher ericholscher left a comment

👍

@@ -361,7 +361,11 @@ def install_core_requirements(self):
negative='sphinx<2',
Copy link
Member

@ericholscher ericholscher Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't inherently related, but I think we should drop the <2 on the positive here too, and likely consider a newer default.

Copy link
Contributor Author

@davidfischer davidfischer Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems easy enough. I'll make another PR for that.

Copy link
Contributor Author

@davidfischer davidfischer Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfischer davidfischer merged commit f3cdffb into master Jun 19, 2020
2 checks passed
@davidfischer davidfischer deleted the davidfischer/feature-flag-latest-rtd-sphinx-ext branch Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants