Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: tweak fuzziness #7225

Merged
merged 2 commits into from Jun 23, 2020
Merged

Search: tweak fuzziness #7225

merged 2 commits into from Jun 23, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 23, 2020

A small change, big improvements in results

A small change, big improvements in results
readthedocs/search/faceted_search.py Outdated Show resolved Hide resolved
@@ -79,7 +84,8 @@ def _get_text_query(self, *, query, fields, operator):
query=query,
fields=fields,
operator=operator,
fuzziness="AUTO",
fuzziness="AUTO:4,6",
prefix_length=1,
Copy link
Member Author

@stsewd stsewd Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one made a lot of difference

Copy link
Member

@ericholscher ericholscher Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think that will make it feel much less random.

@stsewd stsewd requested review from ericholscher and a team Jun 23, 2020
Copy link
Member

@ericholscher ericholscher left a comment

This is a solid change -- in particular the prefix change I agree will make it seem much less broken :)

@@ -79,7 +84,8 @@ def _get_text_query(self, *, query, fields, operator):
query=query,
fields=fields,
operator=operator,
fuzziness="AUTO",
fuzziness="AUTO:4,6",
prefix_length=1,
Copy link
Member

@ericholscher ericholscher Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think that will make it feel much less random.

readthedocs/search/faceted_search.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit dc20232 into master Jun 23, 2020
2 checks passed
@stsewd stsewd deleted the tweak-search branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants