New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImportedFile: remove slug 1/2 #7228
Conversation
We are not using this field, actually we are not even setting it. https://github.com/readthedocs/readthedocs.org/blob/98463241148f86dd37cc38e1102926ca2f976969/readthedocs/projects/tasks.py#L1551-L1559 In production all files have that field empty
The migration needs to be updated after #7274 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are not setting it when creating the object, it wasn't null=True
and it has not default=
value, how it was working?
@humitos who knows |
Weird...
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me -- is part 2 of this work tracked somewhere?
Part two is just to the actual deletion of the field, I was about to make that PR after this one was merged |
We are not using this field,
actually we are not even setting it.
readthedocs.org/readthedocs/projects/tasks.py
Lines 1551 to 1559 in 9846324
In production all files have that field empty.
I'm making this a two-step operation, so we don't have downtime.