Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RemoteRepository.full_name db_index=True #7231

Merged
merged 1 commit into from Jun 30, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 24, 2020

We are going to use this field a lot to check GitHub permissions over these repositories and we want to make this queries faster.

NOTE: it's probably better to fake this migration and create the index manually with CONCURRENTLY to avoid locking the table. See https://realpython.com/create-django-index-without-downtime/

We are going to use this field a lot to check GitHub permissions over these
repositories and we want to make this queries faster.
@humitos humitos requested review from ericholscher and a team Jun 24, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Seems like an obviously useful change. I worry a bit about the migration, but it should hopefully be fine :/

@humitos humitos merged commit 364ef85 into master Jun 30, 2020
2 checks passed
@humitos humitos deleted the humitos/remoterepository-full-name-db-index branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants