Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow Domain name matching production domain to be created #7244

Merged
merged 4 commits into from Jul 8, 2020

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jun 29, 2020

closes #7216

@saadmk11 saadmk11 requested a review from a team Jun 29, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Thanks for putting this together! A few small changes and it'll be 👍

readthedocs/projects/forms.py Outdated Show resolved Hide resolved
readthedocs/projects/forms.py Outdated Show resolved Hide resolved
readthedocs/projects/forms.py Outdated Show resolved Hide resolved
@saadmk11 saadmk11 requested a review from humitos Jul 1, 2020
humitos
humitos approved these changes Jul 8, 2020
@humitos humitos merged commit 2b84382 into readthedocs:master Jul 8, 2020
2 checks passed
@humitos
Copy link
Member

humitos commented Jul 8, 2020

Thanks @saadmk11, you rock!

@saadmk11 saadmk11 deleted the domain-validation branch Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow Domain objects matching production domain to be created
3 participants