Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-linking build limitations for pr builds #7248

Merged
merged 2 commits into from Jun 30, 2020

Conversation

choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 29, 2020

In #7240 there was some confusion about what the build limitations were for PR builds. @humitos mentioned that they're the same as for regular builds, so this adds a sentence to cross-link that page.

Co-authored-by: Santos Gallegos <stsewd@protonmail.com>
@choldgraf
Copy link
Contributor Author

choldgraf commented Jun 30, 2020

oops good catch, also I had no idea that we can reference documentation from the root of the docs with / 🌈

stsewd
stsewd approved these changes Jun 30, 2020
Copy link
Member

@stsewd stsewd left a comment

yeah, a lot of goodies with cross-referencing in sphinx, It's on my list to write a guide with some tips. Thanks for PR!

@choldgraf
Copy link
Contributor Author

choldgraf commented Jun 30, 2020

lemme know if you'd ever like somebody to help take an editing pass at the guide!

@stsewd stsewd merged commit d8bad59 into readthedocs:master Jun 30, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants