Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a case where "tags" is interpreted as a project slug #7284

Merged
merged 1 commit into from Jul 13, 2020

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jul 10, 2020

  • Assumption: There should not be a project named "tags"
  • Longer term this opens up a discussion about banned project names

Issue

Currently https://readthedocs.org/projects/tags/search/ gives a 404. It should return a list of projects for this tag. It does this because the URL route here is looked at first.

- Assumption: There should not be a project named "tags"
- Longer term this opens up a discussion about banned project names
@davidfischer davidfischer requested a review from a team Jul 10, 2020
@stsewd stsewd merged commit 5ec7fb1 into master Jul 13, 2020
2 checks passed
@stsewd stsewd deleted the davidfischer/tag-project-slug-collision branch Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants