Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set hidden on versions via APIv3 #7285

Merged
merged 2 commits into from Jul 23, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 13, 2020

No description provided.

@humitos humitos added the Needed: tests Tests are required label Jul 17, 2020
@humitos humitos removed the Needed: tests Tests are required label Jul 22, 2020
@humitos humitos requested a review from a team Jul 22, 2020
@humitos humitos marked this pull request as ready for review Jul 22, 2020
Copy link
Member

@stsewd stsewd left a comment

We should update the docs

@humitos
Copy link
Member Author

humitos commented Jul 23, 2020

The docs are already updated:

The content of ``body.json`` is like,
.. sourcecode:: json
{
"active": true,
"hidden": false
}

It seems you added it to the docs when added hidden field, but you didn't added to the serializer.

stsewd
stsewd approved these changes Jul 23, 2020
@humitos humitos merged commit dd1ba8c into master Jul 23, 2020
2 checks passed
@humitos humitos deleted the humitos/apiv3-update-hidden branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants