Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SessionAuthentication on APIv3 endpoints #7295

Merged
merged 1 commit into from Jul 23, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 15, 2020

This is required to be able to use the APIv3 from the dashboard in the new templates we are creating.

@agjohnson is this enough for the work you need at the moment?

I'm not documenting this yet so we start using it internally, but after that we should change the documentation a little.

@humitos humitos requested a review from agjohnson Jul 15, 2020
@humitos humitos force-pushed the humitos/session-authentication-apiv3 branch from 26ad65c to 339be4f Compare Jul 15, 2020
This is required to be able to use the APIv3 from the dashboard in the new
templates we are creating.
@humitos humitos force-pushed the humitos/session-authentication-apiv3 branch from 339be4f to f00a62b Compare Jul 15, 2020
@agjohnson
Copy link
Contributor

agjohnson commented Jul 20, 2020

Yeah, i assumed this was the only piece we needed. You can test by simply making a call from the debug console to the API v3 endpoint. It should give you a valid response. That is all I would need to make a client request to APIv3 for dashboard interactions

@humitos
Copy link
Member Author

humitos commented Jul 21, 2020

I tested this with the Browseable API by being logged in. However, I followed your example as well and it worked.

Not logged in,

Screenshot_2020-07-21_13-02-19

After logging in,

Screenshot_2020-07-21_13-02-47

stsewd
stsewd approved these changes Jul 22, 2020
@humitos humitos merged commit 97124cf into master Jul 23, 2020
2 checks passed
@humitos humitos deleted the humitos/session-authentication-apiv3 branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants