Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx: always exclude the build directory #7303

Merged
merged 1 commit into from Jul 21, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 20, 2020

We use the _build/ directory for all builders.
Some users may not have that directory excluded,
leading to some extra copy operations.

Fixes #7200

We use the _build/ directory for all builders.
Some users may not have that directory excluded,
leading to some extra copy operations.

Fixes #7200

# Make sure our build directory is always excluded
exclude_patterns = globals().get('exclude_patterns', [])
exclude_patterns.extend(['_build'])
Copy link
Member Author

@stsewd stsewd Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't problems if the dir is included twice, so I'm ignoring that to keep it simple.

@stsewd stsewd requested a review from a team Jul 20, 2020
Copy link
Member

@humitos humitos left a comment

I thought this directory was excluded by Sphinx by default.

@stsewd stsewd merged commit e4b618d into master Jul 21, 2020
2 checks passed
@stsewd stsewd deleted the exclude-build-dir branch Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build directories are messed up with SHARE_SPHINX_DOCTREE
2 participants