Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer: don't show the version warning for external version #7340

Merged
merged 1 commit into from Jul 30, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 29, 2020

Fixes #7218

@stsewd stsewd requested a review from a team Jul 29, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

if (
not project.show_version_warning or
(base_version and base_version.is_external)
):
return {'is_highest': False}
Copy link
Member

@ericholscher ericholscher Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we're setting this to False here instead of True? Seems if we're opting out of showing it, setting it to True makes more sense, even though I know we likely aren't testing for it.

Copy link
Member Author

@stsewd stsewd Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid running the queries below, that value is only used for the warning message.

Copy link
Member

@ericholscher ericholscher Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha -- just seems like True is a better default for other edge cases, but I don't care too much.

@stsewd stsewd merged commit f125074 into master Jul 30, 2020
2 checks passed
@stsewd stsewd deleted the version-warning branch Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "Not the newest version of this documentation" on PR builds
2 participants