Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task router: small changes #7379

Merged
merged 1 commit into from Aug 18, 2020
Merged

Task router: small changes #7379

merged 1 commit into from Aug 18, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 11, 2020

Just a little refactor (both tasks pass the version_pk as the first
parameter), and docstring updated.

Don't think this is related to #7360... but maybe? I couldn't find anything else related to that problem :/

Just a little refactor (both tasks pass the version_pk as the first
parameter), and docstring updated.
version = build.version
except Build.DoesNotExist:
log.info(
'Build does not exist. Routing task to default queue. build_pk=%s',
Copy link
Member

@ericholscher ericholscher Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this check?

Copy link
Member Author

@stsewd stsewd Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tasks pass the version_pk as the first parameter, so there no need to get the build.

Copy link
Member

@humitos humitos left a comment

Don't think this is related to #7360... but maybe? I couldn't find anything else related to that problem :/

The changes don't seem to do anything in a different way, so I don't think it affect at all. However, the small refactor makes sense.

@stsewd stsewd merged commit 35a32f3 into master Aug 18, 2020
2 checks passed
@stsewd stsewd deleted the task-router branch Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants