Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External providers: better logging for GitLab #7385

Merged
merged 3 commits into from Aug 13, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 13, 2020

Ref #7370

'GitLab project does not exist or user does not have '
'permissions: project=%s',
project,
'GitLab project does not exist or user does not have permissions: '
Copy link
Member

@ericholscher ericholscher Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make sure our logging is consistent here across all providers. I've definitely wanted better logging here in the past, so 👍 on improvements.

Copy link
Member Author

@stsewd stsewd Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, looks like github was already logging this information, and more, I have updated this pr to match both

@stsewd stsewd merged commit b4c04ac into master Aug 13, 2020
2 checks passed
@stsewd stsewd deleted the gitlab-better-login branch Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants