Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip: test new resolver #7412

Merged
merged 1 commit into from Aug 26, 2020
Merged

Pip: test new resolver #7412

merged 1 commit into from Aug 26, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 26, 2020

This will help us find bugs before is installed by default in all builds (october)

Related to #7362

@@ -383,6 +390,7 @@ def install_core_requirements(self):
])

cmd = copy.copy(pip_install_cmd)
cmd.extend(self._pip_extra_args())
Copy link
Member

@humitos humitos Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add it in line 344, next to cache, so they all are together?

            *self._pip_cache_cmd_argument(),

Copy link
Member Author

@stsewd stsewd Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in 334 we are installing pip itself, so the previous version of pip may not support the --use-feature option.

@stsewd
Copy link
Member Author

stsewd commented Aug 26, 2020

Failure on rtd is unrelated, merging

@stsewd stsewd merged commit 583bc67 into master Aug 26, 2020
1 of 2 checks passed
@stsewd stsewd deleted the test-new-resolver branch Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants