Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: remove old endpoint #7414

Merged
merged 3 commits into from Oct 12, 2020
Merged

Search: remove old endpoint #7414

merged 3 commits into from Oct 12, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 26, 2020

No description provided.

@stsewd stsewd requested a review from a team Aug 26, 2020
Copy link
Member

@humitos humitos left a comment

I don't have the full context to do a good review of this, but as far as I can tell, the removal of the old endpoint looks good.

Aren't there any test cases for this endpoint that need to be removed?

@stsewd
Copy link
Member Author

stsewd commented Aug 27, 2020

Aren't there any test cases for this endpoint that need to be removed?

Tests were changed to use the new endpoint when it was implemented. But I'll wait one more week before fulling removing this, but all docs should be pointing at the new endpoint by now.

@humitos
Copy link
Member

humitos commented Oct 1, 2020

Did we already contact people using this endpoint and they already migrated to the new one?

@stsewd
Copy link
Member Author

stsewd commented Oct 1, 2020

I have contacted all of them already, we decided we shouldn't wait they were using something custom or outside rtd as we never documented this api.

Copy link
Member

@ericholscher ericholscher left a comment

I'd like to find a better way of deprecating this for users. Is it easy to return a message/page on that URL linking to the new API? Should we 302 it and then let it fail on the JSON response differences? Not sure if there's a great answer here, but might be a more user-friendly deprecation path.

Not a blocker, but worth considering if it isn't too difficult, but probably not super important in this case.

@stsewd
Copy link
Member Author

stsewd commented Oct 8, 2020

Do you mean something like this at the django or nginx level?

@stsewd stsewd merged commit 1b01ffd into master Oct 12, 2020
2 checks passed
@stsewd stsewd deleted the remove-old-search branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants