Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ES: update dependencies" #7429

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 1, 2020

Reverts #7408 till we contact users using an old version of our extension https://github.com/readthedocs/readthedocs-sphinx-search

humitos
humitos approved these changes Sep 1, 2020
Copy link
Member

@humitos humitos left a comment

Looks good to me.

Some context: while deploying it we found some users still using /docsearch/ API endpoint and that was causing some errors in Sentry because there is a filter that it's not coming back in the ES response anymore. See https://sentry.io/organizations/read-the-docs/issues/1870973719/?project=148442&query=is%3Aunresolved&statsPeriod=14d

@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Sep 1, 2020
@stsewd
Copy link
Member Author

stsewd commented Sep 2, 2020

Going to merge this to make another PR to revert the revert...

@stsewd stsewd merged commit 26f7b3c into master Sep 2, 2020
2 checks passed
@stsewd stsewd deleted the revert-7408-update-es-dep branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants