Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizations: move forms #7438

Merged
merged 1 commit into from Sep 3, 2020
Merged

Organizations: move forms #7438

merged 1 commit into from Sep 3, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 2, 2020

Copy/paste mostly. Changed some docstrings and var names to make the linter happy. And also added a SettingsOverrideObject

@stsewd stsewd requested a review from a team Sep 2, 2020
humitos
humitos approved these changes Sep 3, 2020
Copy link
Member

@humitos humitos left a comment

Copy/paste mostly. Changed some docstrings and var names to make the linter happy

If you copy&paste code and change things, it's good to make a first commit with the copy&paste changes only and then new commits with your changes. This way is easy to see what changed.

I don't have a good way to review all the changes, but I trust you they are correct 😄

return org


class OrganizationSignupForm(SettingsOverrideObject):
Copy link
Member

@humitos humitos Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already know that we need to modify the behavior from Corporate? Is there a PR that is already making usage of this?

Copy link
Member Author

@stsewd stsewd Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already a PR open for that

@stsewd stsewd merged commit ce4adfe into master Sep 3, 2020
2 checks passed
@stsewd stsewd deleted the move-organizations-forms branch Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants