Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Connected Services" form errors to the user #7469

Merged
merged 1 commit into from Sep 9, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 8, 2020

This will inform about,

  • account without password
  • account without verified email address

We override the connections.html file from django-allauth and we lost this
chunk of template code in the middle.

Python code:
https://github.com/pennersr/django-allauth/blob/c19a212c6ee786af1bb8bc1b07eb2aa8e2bf531b/allauth/socialaccount/adapter.py#L123-L139
Template code:
https://github.com/pennersr/django-allauth/blob/c19a212c6ee786af1bb8bc1b07eb2aa8e2bf531b/allauth/templates/socialaccount/connections.html#L18-L20

Screenshot_2020-09-08_15-57-39

This will inform about,

- account without password
- account without verified email address

We override the `connections.html` file from `django-allauth` and we lost this
chunk of template code in the middle.

Python code:
https://github.com/pennersr/django-allauth/blob/c19a212c6ee786af1bb8bc1b07eb2aa8e2bf531b/allauth/socialaccount/adapter.py#L123-L139
Template code:
https://github.com/pennersr/django-allauth/blob/c19a212c6ee786af1bb8bc1b07eb2aa8e2bf531b/allauth/templates/socialaccount/connections.html#L18-L20
@humitos humitos requested review from agjohnson and a team Sep 8, 2020
stsewd
stsewd approved these changes Sep 8, 2020
@@ -18,6 +18,11 @@
{% endblocktrans %}
</p>

{# TODO: style this properly in the new templates #}
Copy link
Member

@stsewd stsewd Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humitos humitos merged commit fb2d744 into master Sep 9, 2020
2 checks passed
@humitos humitos deleted the humitos/connected-service-form-errors branch Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants