Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprojects: fix form #7491

Merged
merged 1 commit into from Oct 21, 2020
Merged

Subprojects: fix form #7491

merged 1 commit into from Oct 21, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 17, 2020

Fixes #7229

@stsewd stsewd force-pushed the fix-subprojects-form branch 2 times, most recently from 8d9aa5a to c2b4f38 Compare September 17, 2020 19:03
@stsewd stsewd requested a review from a team September 17, 2020 19:04
error_msg = 'A subproject with this alias already exists'
self.assertDictEqual(form.errors, {'alias': [error_msg]})

# Change alias to a new alias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be different unit test instead?

readthedocs/projects/forms.py Show resolved Hide resolved
@stsewd stsewd force-pushed the fix-subprojects-form branch 2 times, most recently from da26dc7 to 0972e89 Compare October 6, 2020 22:14
@stsewd stsewd requested a review from a team October 6, 2020 22:15
@stsewd stsewd requested a review from humitos October 21, 2020 16:13
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stsewd stsewd merged commit dbf11b5 into master Oct 21, 2020
2 checks passed
@stsewd stsewd deleted the fix-subprojects-form branch October 21, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't update subproject alias
2 participants