Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back project privacy level #7525

Merged
merged 3 commits into from Oct 26, 2020
Merged

Bring back project privacy level #7525

merged 3 commits into from Oct 26, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 1, 2020

But... only for .com and is used to show the dashboard and build output
of public versions

Closes #2663

@stsewd stsewd requested a review from a team October 1, 2020 19:19
But... only for .com and is used to show the dashboard and build output
of public versions

Closes #2663
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We might need to upgrade the migration if we've had others since this PR was created. I'd merge master to see if it fails CI.

@@ -365,7 +365,7 @@ class Project(models.Model):
choices=constants.PRIVACY_CHOICES,
default=settings.DEFAULT_PRIVACY_LEVEL,
help_text=_(
'Level of privacy that you want on the repository.',
'Should the project dashboard be public?',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better help text. 💯

@stsewd stsewd merged commit 4522c7b into master Oct 26, 2020
2 checks passed
@stsewd stsewd deleted the privacy-level branch October 26, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove project level privacy
2 participants