Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our readthedocs_processor data to our notifications #7565

Merged
merged 2 commits into from Oct 22, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 15, 2020

This fixes an issue where we were sending emails with Contact us at {{ SUPPORT_EMAIL }} but the support email variable was not set and the result was
an empty email.

Using our own readthedocs_processor here we are passing all the same variables
to the notification that to all the Django templates, avoiding this kind of confusions.

This fixes an issue where we were sending emails with `Contact us at {{
SUPPORT_EMAIL }}` but the support email variable was not set and the result was
an empty email.

Using our own `readthedocs_processor` here we are passing all the same variables
to the notification that to all the Django templates, avoiding this kind of confusions.
@humitos humitos requested a review from a team October 15, 2020 10:29
@agjohnson
Copy link
Contributor

Tests appear to be breaking here stil. I'm pushing this to the next release.

@humitos humitos merged commit c85171a into master Oct 22, 2020
2 checks passed
@humitos humitos deleted the humitos/context-procesor-notifications branch October 22, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants