Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings and docker configuration for working with new theme #7578

Merged
merged 2 commits into from Oct 20, 2020

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson added the Improvement Minor improvement to code label Oct 19, 2020
readthedocs/settings/base.py Outdated Show resolved Hide resolved
readthedocs/settings/docker_compose.py Show resolved Hide resolved
Crispy forms fetchs these setting with getattr, and would try to use a
default return value of `None` here.
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agjohnson agjohnson merged commit dbd72aa into master Oct 20, 2020
2 checks passed
@agjohnson agjohnson deleted the agj/ext-theme branch October 20, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants