Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads JS hotfix #7586

Merged
merged 1 commit into from Oct 20, 2020
Merged

Ads JS hotfix #7586

merged 1 commit into from Oct 20, 2020

Conversation

davidfischer
Copy link
Contributor

  • Fix an issue with the publisher not being set correctly
  • Don't make the API call at all if ads are disabled

- Fix an issue with the publisher not being set correctly
- Don't make the API call at all if ads are disabled
@davidfischer davidfischer added the PR: hotfix Pull request applied as hotfix to release label Oct 20, 2020
@davidfischer davidfischer requested a review from a team October 20, 2020 17:20
@@ -177,7 +185,7 @@ function init() {
error: function () {
console.error('Error loading Read the Docs user and project information');

if (!rtd.ad_free && rtd.api_host === 'https://readthedocs.org' && detect_adblock()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed because it's checked on line 139 above.

@davidfischer davidfischer merged commit 137ccea into master Oct 20, 2020
2 checks passed
@davidfischer davidfischer deleted the davidfischer/ads-js-hotfix branch October 20, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants