Remote repository: save and set default_branch #7646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we default to master/trunk when a project is imported, even when the project isn't imported manually. The default_branch is already in the API response of all our supported providers. Questions: - Should we show this in the first form or in the advanced form?
|
#7536 needs to be updated after this PR is merged as a new migration is added here :) |
ericholscher
approved these changes
Nov 19, 2020
| @@ -166,6 +166,7 @@ class Meta: | |||
| fields = ( | |||
| 'description', | |||
| 'documentation_type', | |||
| 'default_branch', | |||
There was a problem hiding this comment.
Is this to allow users to edit this in the Project edit form, or is it required for the import.js to pass it properly?
There was a problem hiding this comment.
Ah, this is on import. I'm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently we default to master/trunk when a project is imported,
even when the project isn't imported manually.
The default_branch is already in the API response of all our supported
providers.
Questions:
Close #7533
Close #7601