Automation Rules: keep history of recent matches #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be amazing to have it merged soon! |
humitos
reviewed
Nov 11, 2020
humitos
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Looks good to me!
I'm pinging @agjohnson here to decide if we can merge this now and then adapt the templates in the new theme. Otherwise, how we should handle this?
|
Yeah, looks like a good addition! Thanks for the ping, I've noted on the new theme project to return to this PR. If anyone is merging any work that touches templates or JS, be sure to ping me so that we can track the addition in the new theme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I did a basic template change for this element, I'm not sure if we should wait for the new templates first or just ship this simple version first or make more changes.
Only the latest 15 matches per project are saved.
Also, I think I figured out why the tests are slow,
trigger_buildwasn't mocked in the other tests, so it was hitting the api till it times out, probably I'll add that change in another PR so is merged faster.Ref #7653
Close #6393