Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ad configuration values if using explicit placement #7669

Merged
merged 1 commit into from Nov 16, 2020

Conversation

davidfischer
Copy link
Contributor

This only applies if the project is setting an explicit placement. This sets the values on the ad element sanely.

Ref: #7623 (comment)

This only applies if the project is setting an explicit placement.
This sets the values sanely
@davidfischer davidfischer requested review from ericholscher and a team Nov 16, 2020
@@ -32,6 +32,11 @@ function create_ad_placement() {
var offset;

if ($(EXPLICIT_PLACEMENT_SELECTOR).length > 0) {
$(EXPLICIT_PLACEMENT_SELECTOR).attr("data-ea-publisher", "readthedocs");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need this to respect the value coming back from the sustainability API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will set it later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, reading through the code, sounds like that's set dynamically after the call returns. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, should get this merged for deploy 👍

@ericholscher ericholscher merged commit e4f85cc into master Nov 16, 2020
3 checks passed
@ericholscher ericholscher deleted the davidfischer/set-ad-config-values branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants