Import page: fix wizard form #7702
Conversation
stsewd
force-pushed
the
fix-wizard-form
branch
2 times, most recently
from
bcf2bad
to
1b5281d
Compare
There was a problem hiding this comment.
This seems fine, but I feel like we probably want to think about this UX a bit more. Will users feel they need to fill out the default_branch in the form? Will they often fill it out with the wrong information? We probably need some JS that dynamically adjusts the default branch to a good default, based on the repo.
Or we should just hide it with CSS or something. I just feel like there is a reason that this wasn't on this form historically, and showing it to users feels wrong without a lot more UX around it.
| @@ -85,7 +85,7 @@ class ProjectBasicsForm(ProjectForm): | |||
|
|
|||
| class Meta: | |||
| model = Project | |||
| fields = ('name', 'repo', 'repo_type') | |||
| fields = ('name', 'repo', 'repo_type', 'default_branch') | |||
There was a problem hiding this comment.
Are we showing users a blank default_branch field on all manual imports now? This seems..not great, and pretty confusing.
There was a problem hiding this comment.
For users importing manually yeah. We do show the help text that says that it will be master/trunk if it's empty, not sure if that's enough, we could also make it hidden so users who import from the vcs would get the correct value. But we still want users who do a manual import to be able to set this value, so not sure.
There was a problem hiding this comment.
The issue here being that building will be broken if they aren't using a standard VCS-derived default branch?
There was a problem hiding this comment.
yeah, we will use master, but everyone is using main, or maybe other names and the first build will fail as the repo doesn't have that branch.
|
We should probably also fix the docstring here to say |
we still use master internally, so changing to main isn't correct there. We could also do a data migration and set to master/trunk for old projects explicitly, and default to main for new ones. But I guess users could also still import an old project that has master as default branch. |
The initial data is set at the class level, this means it doesn't survive for the next form. I'm using the same method the wizard uses to store information per session. This doesn't mean the data is always set as default after saving, it means the default values are going to be set when the user is in the advanced form. So, due to that I have moved the default_branch field to the basic form, this way the form will always have the default branch.
stsewd
force-pushed
the
fix-wizard-form
branch
from
1b5281d
to
1e5de5a
Compare
The initial data is set at the class level,
this means it doesn't survive for the next form.
I'm using the same method the wizard uses to store information per
session.
This doesn't mean the data is always set as default after saving,
it means the default values are going to be set when the user
is in the advanced form.
So, due to that I have moved the default_branch field to the
basic form, this way the form will always have the default branch.
Close #7697