Install six as core requirement for builds #7710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/install-six
branch
from
fb764ca
to
6151333
Compare
Our config file depends on `six` package to check `string_types`, so we need to make sure we have it installed as a core requirement. We were pinning `sphinx<2` which depends on `six`. Now, all the projects using `USE_LATEST_SPHINX` will install just `sphinx` (currently 3.3.1) which does not depends on `six` anymore and all they builds will fail.
humitos
force-pushed
the
humitos/install-six
branch
from
6151333
to
7a9e935
Compare
|
I think this is a good opportunity to start getting rid of implicit dependencies, and just do the logic, seems small to replace. https://github.com/benjaminp/six/blob/c0be8815d13df45b6ae471c4c436cce8c192245d/six.py#L36-L49 |
ericholscher
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Agreed with @stsewd -- we should just fix our logic to not depend on six. If we can't update the PR to do that though, we should ship this PR this week, and add a TODO to change the logic.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Our config file depends on
sixpackage to checkstring_types, so we need tomake sure we have it installed as a core requirement.
We were pinning
sphinx<2which depends onsix. Now, all the projects usingUSE_LATEST_SPHINXwill install justsphinx(currently 3.3.1) which does notdepends on
sixanymore and all they builds will fail.Closes #7705