Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra features: allow to display them conditionally #7715

Merged
merged 3 commits into from Dec 7, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 30, 2020

We need this for .com mainly.

close #7689

@stsewd stsewd changed the title Extra features: allow to display conditionally Extra features: allow to display them conditionally Nov 30, 2020
We need this for .com mainly.
@stsewd stsewd requested a review from a team December 3, 2020 23:56
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@@ -12,6 +12,11 @@

{% block project_edit_content %}

{% if not enabled %}
{% block disabled %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably put the same This beta feature can be enabled by <a href="mailto:{{ SUPPORT_EMAIL }}">asking support</a>. block here for when its disabled, even if that isn't normally happening. I wonder if this should be in a base template, instead of one-off for each feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved it to an include 👍

This is needed for .com to show the plan link
@stsewd stsewd merged commit 2b9d0fb into master Dec 7, 2020
3 checks passed
@stsewd stsewd deleted the allow-to-hide-features branch December 7, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove message about contacting support after the feature is enabled
2 participants