Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lru_cache for caching methods #7751

Merged
merged 1 commit into from Dec 15, 2020
Merged

Use lru_cache for caching methods #7751

merged 1 commit into from Dec 15, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 15, 2020

I'm not sure why I didn't use this before 馃し,
it works just fine for methods, the cache is per instance, so all good.

Maybe because I tried to cache something else that wasn't hashable in
some of this code before? don't know

I'm not sure why I didn't use this before 馃し,
it works just fine for methods, the cache is per instance, so all good.

Maybe because I tried to cache something else that wasn't hashable in
some of this code?
@stsewd stsewd requested a review from a team December 15, 2020 00:11
@stsewd stsewd merged commit 710f171 into master Dec 15, 2020
3 checks passed
@stsewd stsewd deleted the use-lrucache branch December 15, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants