Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set The Right Permissions on GitLab OAuth RemoteRepository #7753

Merged
merged 3 commits into from Dec 16, 2020
Merged

Set The Right Permissions on GitLab OAuth RemoteRepository #7753

merged 3 commits into from Dec 16, 2020

Conversation

saadmk11
Copy link
Member

ref: #7743

humitos
humitos approved these changes Dec 15, 2020
View changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just left a comment to improve the comment.

readthedocs/oauth/services/gitlab.py Outdated Show resolved Hide resolved
stsewd
stsewd approved these changes Dec 16, 2020
View changes
readthedocs/oauth/services/gitlab.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit b5e03f2 into readthedocs:master Dec 16, 2020
3 checks passed
@saadmk11 saadmk11 deleted the gitlab-permission-issue branch December 16, 2020 17:26
@stsewd stsewd mentioned this pull request Dec 16, 2020
Closed
@humitos humitos mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@humitos humitos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saadmk11 @humitos @stsewd