Upgrade Celery and friends to latest versions #7786
Conversation
| # Celery 4.2 is incompatible with our code | ||
| # when ALWAYS_EAGER = True |
There was a problem hiding this comment.
This was solved in 4.3 and 4.4. Tests are not failing anymore because of this.
| # Redis 3.x has an incompatible change and fails | ||
| # https://stackoverflow.com/questions/53331405/django-compress-error-invalid-input-of-type-cachekey | ||
| # https://github.com/sebleier/django-redis-cache/pull/162 |
There was a problem hiding this comment.
I was able to run collectstatic without problem and I haven't seen any obvious error for now.
We are getting the same error on Sentry issue: https://sentry.io/organizations/read-the-docs/issues/2222409449/events/oldest/?project=161479&query=is%3Aunresolved |
We are receiving "Acquire on closed pool" error randomly after running instances for more than ~1 day and calling `self.app.control.cancel_consumer` from our task that kills VM instances. This seems to be a known problem in 3.x Celery verions but some users reported that it's still present in <4.4. - celery/celery#4410 (comment) - https://stackoverflow.com/questions/36789805/celery-kombu-fails-after-self-connections-acquire - celery/celery#1839 Celery released 5.x on September, so I'm upgrading to it directly as a test. If everything keep working together, we can leave it. Otherwise, we can go back to latest 4.4.x series: 4.4.7.
humitos
force-pushed
the
humitos/upgrade-celery
branch
from
5876ad9
to
667ceac
Compare
|
I'm testing this in |
|
I spun up an instance of |
We are receiving "Acquire on closed pool" error randomly after running instances
for more than ~1 day and calling
self.app.control.cancel_consumerfrom ourtask that kills VM instances.
This seems to be a known problem in 3.x Celery verions but some users reported
that it's still present in <4.4.
Celery released 5.x on September, so I'm upgrading to it directly as a test. If
everything keep working together, we can leave it. Otherwise, we can go back to
latest 4.4.x series: 4.4.7.
Sentry issue on production: https://sentry.io/organizations/read-the-docs/issues/2101960715/?project=148442&query=is%3Aunresolved+builds&statsPeriod=14d
Requires: https://github.com/readthedocs/readthedocs-ops/pull/837
Requires: readthedocs/common#79