Add management command to Sync RemoteRepositories and RemoteOrganizations #7803
Conversation
| self.stdout.write( | ||
| self.style.SUCCESS( | ||
| 'Found %s user(s) with the given parameters' % users.count() | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Can we also show the total number of users that need to be resync before taking the max_users slice?
There was a problem hiding this comment.
users.count() shows the total number of users that needs to be re-synced according to the filters. The next count is the count after the slice. Did you mean something else?
There was a problem hiding this comment.
Yeah, I wanted to know the total of users that needs to be synced without applying sync_users or skip_users. So, maybe those filters need to be applied to users_to_sync instead of users. Don't you think?
In that case we will have:
- Found TOTAL user(s) to sync in total
- Re-syncing VCS Providers for FILTERED_USERS user(s) with given parameters
This gives us a clear number about "where we are" when running this command. Every time we run it we know exactly how many users still need re-syncing.
|
I think we can add a |
|
| @@ -40,13 +40,20 @@ def add_arguments(self, parser): | |||
| default=False, | |||
| help='Force re-sync VCS provider data even if the users are already synced.', | |||
| ) | |||
| parser.add_argument( | |||
| '--no-dry-run', | |||
There was a problem hiding this comment.
I think it's more common to use the opposite here: --dry-run
There was a problem hiding this comment.
Okay, I added this so that we don't accidentally trigger tasks
humitos
merged commit dc40044
into
readthedocs:remote-repository-normalization
This is the simple implementation of the management command that can be used in production to Sync
RemoteRepositoriesandRemoteOrganizationsfor users. This will be useful to populate the new table created for the normalization.Options
--queuename of the celery queue for the tasks to be triggered with. (Default: resync-oauth)--skip-usersSkip re-sync VCS provider data for specific users. (Default: [])--usersRe-sync VCS provider data for specific users only. (Default: [])--max-usersmaximum number of users that should be synced. (Default: 100)--forceForce re-sync VCS provider data even if the users are already synced.--dry-runDo not trigger tasks for VCS provider re-sync.Example:
python manage.py sync_vcs_data --queue resync-oauth --max-users 500python manage.py sync_vcs_data --users saadmk11 test_user --skip-users another_userThis management command triggers 1
sync_remote_repositoriestask per user.closes #7791