Add version_changed signal #7878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to know when to purge the footer. With ext#404 we now purge the footer from all versions when we purge a version as well. So this is the only missing place left to purge the footer.
| @@ -88,6 +89,8 @@ def save(self, commit=True): | |||
| obj = super().save(commit=commit) | |||
| if obj.active and not obj.built and not obj.uploaded: | |||
| trigger_build(project=obj.project, version=obj) | |||
| if self.has_changed(): | |||
| version_changed.send(sender=self.__class__, version=obj) | |||
There was a problem hiding this comment.
Do we not want this on the model instead of the form? Seems like having it in the model save method is better, unless there's a reason we can't do it there.
There was a problem hiding this comment.
Models don't keep track of changed data. We could do this by overriding the init method of the models, but isn't guaranteed that the form will use the model in that way.
ericholscher
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is useful to know when to purge the footer.
With ext#404 we now purge the footer from all versions when we purge a version as well.
So this is the only missing place left to purge the footer.