Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use admin user for SLUMBER API on local environment #7925

Merged
merged 1 commit into from Feb 18, 2021
Merged

Use admin user for SLUMBER API on local environment #7925

merged 1 commit into from Feb 18, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 17, 2021

By default on local docker environment we were usign test user for SLUMBER
API. However, this user is not created at --init and it has to be created
manually.

To avoid this extra step, we are defining admin user for SLUMBER which is
created automatically on init.

@humitos
Use admin user for SLUMBER API on local environment
43e4f9c 
By default on local docker environment we were usign `test` user for SLUMBER
API. However, this user is not created at `--init` and it has to be created
manually.

To avoid this extra step, we are defining `admin` user for SLUMBER which is
created automatically on init.
@humitos humitos requested a review from a team February 17, 2021 17:43
@ericholscher
Copy link
Member

Is there a strong reason to change the actual login? Seems like it will just break things, when the test user seems fine for now?

@humitos
Copy link
Member Author

humitos commented Feb 17, 2021

Currently, there is no test user; that's my point. We need either create another super user in https://github.com/rtfd/readthedocs-common/blob/5ff15ec196a50ac538632e52eef1763ee0caa045/dockerfiles/scripts/createsuperuser.py#L4 or use the admin one that we have already created. This PR does the later one.

In case we want to create test as well, it needs to be superuser also, so there is no big difference in using the admin one.

@humitos
Copy link
Member Author

humitos commented Feb 17, 2021

It's basically the same. However, if we want to have test user for builders separated from admin user for general usage, I opened the required PR in common/: readthedocs/common#83 😄

@ericholscher
Copy link
Member

Ah, I see. I do have an admin user, so that should be good then :) I didn't realize we were already creating it.

@humitos humitos merged commit f864881 into master Feb 18, 2021
3 checks passed
@humitos humitos deleted the humitos/slumber-admin-local-env branch February 18, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@humitos @ericholscher