Route external versions to the queue were default version was built #7933
Conversation
When a build for an external version is triggered, we find the the last build for the default version and use the same queue for this version. This should make the build to always succeed when it's merged into the default version since it's using the same build queue. I thought this was fixed originally in #7912 but that PR was wrong.
humitos
force-pushed
the
humitos/route-external-versions
branch
from
aff57c9
to
93adf08
Compare
| if version.type == EXTERNAL: | ||
| last_build_for_default_version = ( | ||
| project.builds | ||
| .filter(version__slug=project.get_default_version()) |
There was a problem hiding this comment.
I wonder if we should filter success=True here? Though I guess that isn't really a good check, and might miss ones without a successful build on the default project.
I wonder if what we really want is an attribute on the project that keeps track of what queue it should use? I don't know if there's a "correct" way of handling this for every case though.
There was a problem hiding this comment.
I wonder if what we really want is an attribute on the project that keeps track of what queue it should use?
I thought about something like this as well but I wasn't sure it was a good idea. We could talk a little more about this and share our thoughts. I think this PR is fine for now, tho.
I don't know if there's a "correct" way of handling this for every case though.
Yeah, 😞
When a build for an external version is triggered, we find the the last build
for the default version and use the same queue for this version.
This should make the build to always succeed when it's merged into the default
version since it's using the same build queue.
I thought this was fixed originally in
#7912 but that PR was wrong.