Embed: refactor tests #7947
Merged
Embed: refactor tests #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make them more readable by splitting the html from the json file, similarly to what we do with the search tests. - Don't do two calls to storage, just open the file. - Remove unused requests adaptor (probably was something used before storage) Didn't bother to split the mkdocs json file, since that mkdocs doesn't output that kind of format anymore, we should start reading from the html file itself.
stsewd
force-pushed
the
refactor-embed-tests
branch
from
df7b8cd
to
d00deb5
Compare
humitos
approved these changes
Feb 24, 2021
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Merged
agjohnson
pushed a commit
that referenced
this pull request
Mar 2, 2021
* Embed: refactor tests - Make them more readable by splitting the html from the json file, similarly to what we do with the search tests. - Don't do two calls to storage, just open the file. - Remove unused requests adaptor (probably was something used before storage) Didn't bother to split the mkdocs json file, since that mkdocs doesn't output that kind of format anymore, we should start reading from the html file itself. * Apply suggestions from code review Co-authored-by: Manuel Kaufmann <humitos@gmail.com> * Remove requests mock Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similarly to what we do with the search tests.
storage)
Didn't bother to split the mkdocs json file,
since that mkdocs doesn't output that kind of format anymore,
we should start reading from the html file itself.
Based on #7943