Embed: add more tests #7962
Merged
Embed: add more tests #7962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make them more readable by splitting the html from the json file, similarly to what we do with the search tests. - Don't do two calls to storage, just open the file. - Remove unused requests adaptor (probably was something used before storage) Didn't bother to split the mkdocs json file, since that mkdocs doesn't output that kind of format anymore, we should start reading from the html file itself.
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
- Use version.is_sphinx_type to choose between mkdocs or sphinx - Avoid nested code - Check for multiple queries inside a loop instead of several if's - Clean links only to the end result node, not to the whole body
Now is more easy to add more.
ericholscher
approved these changes
Mar 2, 2021
| self.version = self.project.versions.get(slug=LATEST) | ||
|
|
||
| settings.USE_SUBDOMAIN = True | ||
| settings.PUBLIC_DOMAIN = 'readthedocs.io' |
There was a problem hiding this comment.
Is there a reason to do this here instead of @override_settings?
There was a problem hiding this comment.
override_settings doesn't work with pytest's style tests. pytest provides the settings fixture instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now is more easy to add more.
Based on #7955