Make SupportView login_required #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Mar 9, 2021
readthedocs/urls.py
Outdated
| @@ -26,7 +27,7 @@ | |||
| TemplateView | |||
| .as_view(template_name='security.txt', content_type='text/plain'), | |||
| ), | |||
| url(r'^support/$', SupportView.as_view(), name='support'), | |||
| url(r'^support/$', login_required(SupportView.as_view()), name='support'), | |||
There was a problem hiding this comment.
We use this mxin in our code base
There was a problem hiding this comment.
Gotcha, should probably chagne
as well.There was a problem hiding this comment.
Looks like Django has this builtin now: https://docs.djangoproject.com/en/2.2/topics/auth/default/#django.contrib.auth.mixins.LoginRequiredMixin
There was a problem hiding this comment.
yeah, our mixin basically inherits from that, I think we can use django's mixin directly, don't think we would be adding any other logic there.
ericholscher
force-pushed
the
auth-support-form
branch
from
1758dc9
to
c0fc824
Compare
Use PrivateViewMixin
ericholscher
force-pushed
the
auth-support-form
branch
from
c0fc824
to
239c4e3
Compare
stsewd
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.