Stripe Checkout: handle duplicated wehbook #8002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we receive a webhook multiple times, we fetch the GoldUser already created and update its fields.
agjohnson
reviewed
Mar 11, 2021
| @@ -52,10 +52,6 @@ class GoldUser(models.Model): | |||
| stripe_id = models.CharField(max_length=255) | |||
| subscribed = models.BooleanField(default=False) | |||
|
|
|||
| # TODO: these are managed completely by Stripe now; we could remove them | |||
| last_4_card_digits = models.CharField(max_length=4, null=True, blank=True) | |||
| business_vat_id = models.CharField(max_length=128, null=True, blank=True) | |||
There was a problem hiding this comment.
I assume we probably want to make sure that the users that did specify a VAT actually have this configured in Stripe on their subscription as well.
There was a problem hiding this comment.
Good point! I checked this with a small script:
users = []
for g in GoldUser.objects.exclude(business_vat_id__isnull=True).exclude(business_vat_id=''):
customer = stripe.Customer.retrieve(g.stripe_id)
stripe_vat = customer.tax_ids.data[0].value
if stripe_vat != g.business_vat_id:
subscriptions = stripe.Subscription.list(customer=g.stripe_id)
users.append((g.user.username, stripe_vat, g.business_vat_id, len(subscriptions.data)))and I can say that all the users we have business_vat_id for has the same tax id on Stripe.
We had this event registered but it wasn't added to the list of handled events.
We were returning `None` in some cases and that makes Django to return a 500.
Stripe checkout: handle events
ericholscher
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If we receive a webhook multiple times, we fetch the GoldUser already created and update its fields.
This PR also removes some old and unused payment code.