Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed: validate query arguments #8003

Merged
merged 3 commits into from Mar 11, 2021
Merged

Embed: validate query arguments #8003

merged 3 commits into from Mar 11, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 11, 2021 •
edited

  • Validate that the correct arguments are given
  • Don't return http requests from the parser
  • Always update doc from path (in case path is given by the url)
  • Hit the API to test things

@stsewd stsewd force-pushed the embed-validate-api branch 3 times, most recently from d290d1f to 762c572 Compare March 11, 2021 01:52
@stsewd stsewd marked this pull request as ready for review March 11, 2021 01:53
ericholscher
ericholscher approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having these test more of the actual serving code is 💯

readthedocs/embed/views.py Outdated Show resolved Hide resolved
readthedocs/embed/tests/test_api.py Show resolved Hide resolved
@stsewd stsewd enabled auto-merge (squash) March 11, 2021 17:12
@stsewd stsewd merged commit e65755f into master Mar 11, 2021
3 checks passed
@stsewd stsewd deleted the embed-validate-api branch March 11, 2021 17:17
humitos pushed a commit that referenced this pull request Mar 15, 2021
@stsewd @humitos
Embed: validate query arguments (#8003)
2462462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsewd @ericholscher