Test proxied embed API #8051
Merged
Test proxied embed API #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the url name to match the others and have the same name as the proxied one. - Divide the test so is easy to test the proxied version.
stsewd
force-pushed
the
test-proxied-embed-api
branch
from
26b0018
to
a238f16
Compare
ericholscher
approved these changes
Mar 29, 2021
| @@ -36,6 +36,9 @@ def setup_method(self, settings): | |||
| settings.USE_SUBDOMAIN = True | |||
| settings.PUBLIC_DOMAIN = 'readthedocs.io' | |||
|
|
|||
| def get(self, client, *args, **kwargs): | |||
| return client.get(*args, **kwargs) | |||
There was a problem hiding this comment.
Probably could use a docstring explaining why this is here -- I assume to override elsewhere?
There was a problem hiding this comment.
I just added one. It's overridden in the proxied api tests (in this same file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxied one.