Build environment: allow to run commands with a custom user #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
allow-custom-user
branch
from
59e362c
to
1e7d010
Compare
stsewd
force-pushed
the
allow-custom-user
branch
from
1e7d010
to
2255ac8
Compare
humitos
approved these changes
Mar 30, 2021
| @@ -84,6 +83,8 @@ class BuildCommand(BuildCommandResultMixin): | |||
| :param combine_output: combine stdout/stderr, default=True | |||
| :param input_data: data to pass in on stdin | |||
| :type input_data: str | |||
| :param str user: User used to execute the command, it can be in form of ``user:group`` | |||
There was a problem hiding this comment.
Suggested change
| :param str user: User used to execute the command, it can be in form of ``user:group`` | |
| :param str user: user from inside the container to execute the command, it can be in form of ``user:group`` |
There was a problem hiding this comment.
This is the base class, not the docker implementation. But we use only the docker implementation, so don't know.
There was a problem hiding this comment.
Not sure what's best here. Either seems fine to me, given its on the base class.
ericholscher
approved these changes
Mar 30, 2021
| @@ -84,6 +83,8 @@ class BuildCommand(BuildCommandResultMixin): | |||
| :param combine_output: combine stdout/stderr, default=True | |||
| :param input_data: data to pass in on stdin | |||
| :type input_data: str | |||
| :param str user: User used to execute the command, it can be in form of ``user:group`` | |||
There was a problem hiding this comment.
Not sure what's best here. Either seems fine to me, given its on the base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step closer to allow running apt install. Confirmed that using setting the user as root is able to use apt after the container was created with other user, so all good.
Note: this user isn't being used in the "Local build command" as there isn't an option like that, we could change the command to execute
su {user} -c "{cmd}"if we want to support local machines as build environments.