Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO: add small paragraph mentioning how to enable it on commercial #8063

Merged
merged 4 commits into from Apr 6, 2021
Merged

SSO: add small paragraph mentioning how to enable it on commercial #8063

merged 4 commits into from Apr 6, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 31, 2021

  • remove note saying that it's currently on beta
  • add paragraph explaining how to enable VCS SSO
  • add paragraph explaining how to enable Google SSO

@humitos
SSO: add small paragraph mentioning how to enable it on commercial
4f26ef2 
- remove note saying that it's currently on beta
- add paragraph explaining how to enable VCS SSO
- add paragraph explaining how to enable Google SSO
@humitos humitos requested a review from a team March 31, 2021 16:32
agjohnson
agjohnson reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copy edits. I didn't realize Google changed the name of Gsuite or whatever it was previously. It's now Google Workspace 🤷

docs/commercial/single-sign-on.rst Outdated Show resolved Hide resolved
docs/commercial/single-sign-on.rst Show resolved Hide resolved
docs/commercial/single-sign-on.rst Outdated Show resolved Hide resolved
docs/commercial/single-sign-on.rst Outdated Show resolved Hide resolved
@humitos humitos requested a review from agjohnson April 6, 2021 07:48
ericholscher
ericholscher approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@ericholscher ericholscher merged commit 34c9edf into master Apr 6, 2021
@ericholscher ericholscher deleted the humitos/enable-sso-docs branch April 6, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@humitos @ericholscher @agjohnson